Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

** does not match zero directories #3

Open
houmain opened this issue Feb 23, 2021 · 2 comments
Open

** does not match zero directories #3

houmain opened this issue Feb 23, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@houmain
Copy link

houmain commented Feb 23, 2021

Hi, thank you for this nice library!

I think glob::rglob("dir/**/*.ext") should match:

  • dir/file.ext
  • dir/sub/file.ext
  • dir/sub/sub/file.ext

Currently it only matches:

  • dir/sub/file.ext
  • dir/sub/sub/file.ext

Or how else one can recursively get all .ext files within dir?

@p-ranav
Copy link
Owner

p-ranav commented Feb 23, 2021

Yes, I agree. Glob in this case should include dir/file.ext. Thanks for reporting!

@destructor64
Copy link

Is this issue fixed with the merge of #26 or still open? We are using this library in a project and in our testing, this still doesn't work.

If I have the following file tree:

$ tree test
test
|-- dir
|   |-- dir1
|   |   `-- test2.txt
|   `-- test1.txt
`-- test0.txt

and try to use the rglob function with the pattern test/**/*.txt on the folder test, it selects test1.txt and test2.txt, but not test0.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants