[enhancement] Add netifaces requirement to pyproject.toml #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay I'm not experienced with poetry, not sure how to fix that CI check. |
p0dalirius
changed the title
|
Thanks @AdrianVollmer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks again for merging #68.
Unfortunately, I just realized the
netifacesrequirement is not being installed and first I wasn't sure why. I added it to therequirements.txt, which is read bysetup.py, but it's not being picked up. Then I realized there is also apyproject.tomlwhich builds the package with poetry.This PR adds the
netifacesrequirement to that list also.