Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor providers #12

Open
sneakers-the-rat opened this issue Sep 12, 2024 · 0 comments
Open

refactor providers #12

sneakers-the-rat opened this issue Sep 12, 2024 · 0 comments

Comments

@sneakers-the-rat
Copy link
Contributor

sneakers-the-rat commented Sep 12, 2024

providers are currently all over the map, one of the last major things that needs to be fixed. Their design is, dare i say, batshit and bullshit. and i am allowed to say that because i designed them.

What we want:

  • A way of abstracting getting models..
  • from a variety of sources
  • on-demand (ie. we might only have the NWB schema and need to generate the linkml and pydantic models)
  • with correctly resolved versions

TODO:

  • just build into nwb_models or else use it for the namespace everywhere
  • split out sources into separate classes, switching between the builtin models and cached models is messy as hell
  • use the ectopic model finder to replace much of the pydantic provider, ideally the interface would just be to from nwb_models.{namespace}.{version}.{schema} import {class}
  • make add_schema methods rather than build, which make for clearer semantics - when loading an nwb file, add all the models we don't have to the cache directory, and then we can just access them forever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant