Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion of constants to their MLIR counterparts #12

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

asl
Copy link
Collaborator

@asl asl commented Jan 23, 2025

Also required adding handling of Type_InfInt, type lowering and some constant casts that were left by type inference

@asl asl requested a review from qobilidop January 23, 2025 19:20
@asl asl changed the base branch from mlir-basic to main January 31, 2025 19:43
@asl asl changed the base branch from main to mlir-basic January 31, 2025 19:57
@asl asl force-pushed the mlir-translate-const branch from 5faa064 to a871735 Compare January 31, 2025 20:32
@asl asl changed the base branch from mlir-basic to main January 31, 2025 20:32
Signed-off-by: Anton Korobeynikov <[email protected]>
@asl asl force-pushed the mlir-translate-const branch from 4de6a4e to 7ef343c Compare January 31, 2025 20:39
@@ -5,6 +5,7 @@ on:
branches: [ main ]
pull_request:
branches: [ main ]
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this used to trigger the workflow manually? Do we still need to keep it here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it just in case. Won't hurt :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement conversion of Declaration_Constant to MLIR op Lower basic P4 types to their dialect counterparts
2 participants