Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript definitions #30

Open
jstarry opened this issue Jul 8, 2021 · 5 comments
Open

Add typescript definitions #30

jstarry opened this issue Jul 8, 2021 · 5 comments

Comments

@jstarry
Copy link

jstarry commented Jul 8, 2021

Problem

There are no type definitions available for TypeScript users

@jstarry
Copy link
Author

jstarry commented Jul 11, 2021

@pabigot I'd like to tackle this by migrating the project to use TypeScript and auto-generate the type definitions. Is this a change you would accept?

@pabigot
Copy link
Owner

pabigot commented Jul 11, 2021

I don't know; I did play with TypeScript a while back, but not enough to use it. Depends on how much of a maintenance impact it has.

@bmeeder22
Copy link

+1 would like this as well

@dfl-zeke
Copy link

+1 it's must have for this kind of lib.

@jstarry
Copy link
Author

jstarry commented Oct 19, 2021

@bmeeder22 @dfl-zeke just a heads up that Solana maintains a separate fork and npm package @solana/buffer-layout that you can use for TypeScript types until those changes are upstreamed into this repo. You can find it here: https://github.com/solana-labs/buffer-layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants