Allow for returning a dataframe from gget.mutate, w/ more context #169
+23
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retained two additional columns for the dataframe: mutation_start and mutation_end. Which avoids the need to manually re-parse mutation strings if needed later on.
Additionally, all the extra info in the dataframe is lost in the python API since there are operations done on the dataframe that are copy-on-write which means that inputted dataframes with the
update_df
flag set to True only gain two potential columns:mutation_type
andwt_sequence_full
, whereas I would like all the additional context in my dataframe.To combat this, I made it so that when out=None and update_df=True, the function will return a dataframe. Otherwise it will revert to the previous behavior.
Let me know if you have any feedback!