Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document origin of HCR values #11

Open
iantaylor-NOAA opened this issue Nov 19, 2020 · 2 comments
Open

document origin of HCR values #11

iantaylor-NOAA opened this issue Nov 19, 2020 · 2 comments
Assignees

Comments

@iantaylor-NOAA
Copy link
Contributor

Values of the slope and intercept associated with the different HCRs are hardwired in
https://github.com/pacific-hake/runhakemse/blob/master/R/run_MSE_HCR.R#L24-L33
It would be good to better document the origin of these values (regression on the TACs set by the JMC and realized catch) and potentially replace with the code to do the regression (recognizing that updating the range of years over which the regression is applied would be a much bigger change).

@iantaylor-NOAA
Copy link
Contributor Author

I think those values are the slope and intercept parameters from the linear models run on these lines:
https://github.com/pacific-hake/pacifichakemse/blob/master/R/calc_tac_estimated_vs_realized.R#L41-L42
but I haven't run the code in that file to confirm.

@iantaylor-NOAA
Copy link
Contributor Author

Using this issue to note that the HCR options in Stock Synthesis (and in the hake assessment in particular) should be checked to make sure there is a match with the MSE calculation.

  • check that fixed values are parameters from linear models as noted in comment above
  • check that HCR calculation in SS matches MSE calculation (and compare with our write-ups and the hake treaty as well)

@iantaylor-NOAA iantaylor-NOAA self-assigned this Dec 1, 2020
@aaronmberger-nwfsc aaronmberger-nwfsc transferred this issue from pacific-hake/runhakemse May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant