Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail a package that includes font_size in it's preferences #26

Open
keith-hall opened this issue Jul 12, 2018 · 1 comment
Open

fail a package that includes font_size in it's preferences #26

keith-hall opened this issue Jul 12, 2018 · 1 comment

Comments

@keith-hall
Copy link

There was recently a discussion on Discord whereby someone was unable to change the font size on specific syntaxes. It initially seemed related to sublimehq/sublime_text#1551, but it turned out that the package contained a syntax specific settings file with font_size declared. As Sublime Text's Preferences menu -> Settings - Syntax Specific opens the Default preferences and the User syntax specific preferences side by side, it wasn't easy to find that the package declared font_size in it's syntax specific preferences without looking at the package directly.

I propose that packages which set font_size in their preferences should fail the review.
Maybe it'd be a good idea to also have a warning if syntax specific preferences are used, for the human reviewer to check if the readme contains some tips relating to it, to avoid similar problems with other "hidden" preferences.

@FichteFoll
Copy link
Member

As a note to myself (and others): there should be other settings that should never be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants