FEATURE: Remove jQuery

[VincentTam]

Feature Request

Is your feature request related to a problem?

Just a question.

Solution

As in title.

Alternatives

Keep using jQuery

Additional Context

[Add any other context or screenshots about the feature request here.]

[pacollins]

I would actually like to dump jQuery for vanilla JS. If I remember correct, the issue is with FancyBox at the moment. I did read they are working on a vanilla JS version.

[VincentTam]

Lemme write an XHR version of

hugo-future-imperfect-slim/assets/js/staticman.js

Lines 18 to 36 in 4d237ca

	$.ajax({
	type: $(this).attr('method'),
	url: ['https:/', api, 'v3/entry', gitProvider, username, repo, branch, 'comments'].join('/'),
	data: $(this).serialize(),
	contentType: 'application/x-www-form-urlencoded',
	success: function (data) {
	showAlert('success');
	setTimeout(function(){ clearForm() }, 3000); // display success message for 3s
	$(form).removeClass('loading');
	},
	error: function (err) {
	console.log(err);
	showAlert('failed');
	$(form).removeClass('loading');
	}
	});
	return false;
	});

[VincentTam]

I would actually like to dump jQuery for vanilla JS. If I remember correct, the issue is with FancyBox at the moment. I did read they are working on a vanilla JS version.

@pacollins How much IE support do you want? Some function like fetch() isn't IE-compatible, while some like classList.remove() needs ≥ IE10. I find re-inventing the wheel like https://github.com/onweru/hugo-swift-theme/blob/7d940a9e76fd11f4395b90d8f117422f182fb089/assets/js/index.js#L62-L81

  function pushClass(el, targetClass) {
    if (isObj(el) && targetClass) {
      elClass = el.classList;
      elClass.contains(targetClass) ? false : elClass.add(targetClass);
    }
  }

painful. I'm writing a vanilla replacement compatible with IE10.

[pacollins]

Unless someone has a good reason to support IE in 2021 (we don't have legacy programs we maintain), I say encourage modern browsers.

…

On Wed, Mar 10, 2021, 7:35 PM Vincent Tam ***@***.***> wrote: I would actually like to dump jQuery for vanilla JS. If I remember correct, the issue is with FancyBox at the moment. I did read they are working on a vanilla JS version. @pacollins <https://github.com/pacollins> How much IE support do you want? Some function like fetch() isn't IE-compatible, while some like classList.remove() needs ≥ IE10. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#231 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWVJSMBVSZHDYO4FCYIJ23TDAF5HANCNFSM4YW6ZRAA> .