This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 196
Convert to SCSS Modules #253
Open
pacollins
wants to merge
34
commits into
master
Choose a base branch
from
scss-modules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description⚠️ WIP - Do not merge! ⚠️
Convert from a single
SCSS
file toSCSS
modules to allow better customization and updates.Changes
❌ Removed ❌
Templates (HTML)
partials/site-sidebar.html
❌ Removed (Merged intopartials/site-footer.html
)CSS
nav#site-nav
❌ Removed$breakpoints
and@include break($breakpoint)
❌ Removed-up
suffix (ex.$desktop-up
->$desktop
)#site-intro header
container ❌ Removed#site-intro main
container ❌ Removed#site-intro footer
container ❌ Removed.article-terms-link
❌ Removed#recent-posts header
container ❌ Removed#recent-posts footer
container ❌ Removed#categories header
container ❌ Removed#categories footer
container ❌ RemovedTemplates (HTML)
partials/socnet-icon.html
partials/social-icons.html
CSS
.nav .link
.nav-link
menu#site-nav-menu.flyout-menu.menu
nav#site-nav-menu.flyout-menu
.share-toggle
..search-toggle
,.nav-toggle
.toggle
+.share-button
,.search-button
, or.nav-button
#search
(#search-input.active
,#search-results.active
).active
to#search
and ❌ Removed from#search-input
and#search-results
.socnet-icons
.social-icons
.title
.post-description
.meta
.post-meta
.content
.post-content
section#site-sidebar
footer#site-footer
#mini-bio
#about
footer#site-footer
section#copyright
Motivation and Context
[Why is this change required? What problem does it solve?]
Progress towards #252
Closes #250
Progress towards #244
Progress towards #218
Closes #164
Closes #178
Screenshots (if appropriate):
N/A
Checklist:
theme.toml
, as applicable.