dateTime matcher optional support

[s1apped]

Hi,

I wanted to use formatter optional functionality to match dateTime e.g
datetime("start", "yyyy-MM-dd'T'HH:mm:ss[.[SSSSSSSSS][SSSSSSSS][SSSSSSS][SSSSSS][SSSSS][SSSS][SSS][SS][S]]'Z'", Instant.now());

It looks like it should on provider side (checked by debugging matcher) but consumer is having problems and generates

"start":"2024-05-13T21:35:44.801971000801971008019710801971801978019801808Z

Is this supported / am I doing something wrong?

Thanks!

[rholshausen]

Why would you want to use such a format? Just give the max number of digits expected: 3 for microsecond precision and 6 or 9 for nanosecond precision.

What you have given will provide the seconds fraction over and over.

[s1apped]

Using this format I can parse String date with ranging from 2024-05-13T21:35:44 to 2024-05-13T21:35:44.123456789. The example is little extreme but the idea was to have a bit more flexible contract where Consumer doesn't care about milis so when Provider will start sending with precision 5 instead of 3 contract isn't broken

[sverdiyev]

taking into account the default serialization of Instant, i think this is relevant.
What other options are there to Match all possible default serializations of Instant.now()?

[sverdiyev]

Did you manage to find the answer @s1apped ? :)
Could you please take a look into this once again please? @rholshausen

[sverdiyev]

I've used this, seemed to work

    static final String INSTANT_ISO_DATETIME_FORMAT =
            "\\d{4}-[01]\\d-[0-3]\\dT[0-2]\\d:[0-5]\\d:[0-5]\\d(\\.\\d{1,9})?([+-][0-2]\\d:[0-5]\\d|Z)";

   @Test
    void verifyIsoDateformatRegexp() {

        Pattern pattern = Pattern.compile(INSTANT_ISO_DATETIME_FORMAT);

        assertAll(
                // should match
                () -> assertThat("2020-01-02T14:40:01.123456789Z").matches(pattern), // instant with 9 nanos
                () -> assertThat("2020-01-02T14:40:01.1Z").matches(pattern), // instant with 1 nano
                () -> assertThat("2020-01-02T14:40:01Z").matches(pattern), // instant without nanos
                () -> assertThat("2020-01-02T14:40:01+02:00").matches(pattern), // timezone without Z
                () -> assertThat("2020-01-02T14:40:01-07:30").matches(pattern), // timezone without Z

                // Should not match
                () -> assertThat("2020-01-02T14:40Z").doesNotMatch(pattern), // no seconds
                () -> assertThat("2020-01-02T14:40:01.123123123").doesNotMatch(pattern), // no timezone
                () -> assertThat("2020-01-02T14:40:01-1").doesNotMatch(pattern), // incorrect numeric timezone
                () -> assertThat("2020-01-02").doesNotMatch(pattern), // no time, only date
                () -> assertThat("some-gibberish").doesNotMatch(pattern));
    }

new PactDslJsonBody()
                        .object("Data", looksLike()
                                .stringMatcher("CreationDateTime", INSTANT_ISO_DATETIME_FORMAT)