feat: add AdaptivePrimaryButton components
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a temporary sample button components with fluent-ui widget by using `FilledButton` - add a temporary sample use-case for this widget - update `main` file & add `FluentApp` to `themeBuilder` section so that we can use fluent-ui widgets - update `main.directories.dart`
- add/create `RequestStateEnum` for handling different state of components - add/create `AdaptiveButtonContentWidget` - update `AdaptivePrimaryButton` - update `adaptivePrimaryButtonUseCase` - update `AppThemeData` & add `lightAccentColors` & `darkAccentColors` - update `main` file & add a knobs for selecting & changing accent colors - update `main.directories.dart` - code style
PouriaMoradi021
force-pushed
the
feat/add-button-components-states-modes
branch
from
032267e to
af49c74
Compare
- add/create `AdaptiveSecondaryButton` widget - add/create `adaptiveSecondaryButtonUseCase` - add/create `AppColors`
- add some tests for different states of `AdaptivePrimaryButton` - add some tests for different states of `AdaptiveSecondaryButton`
PouriaMoradi021
force-pushed
the
feat/add-button-components-states-modes
branch
from
98aeec4 to
4f548f4
Compare
phoenixit99
reviewed
Jan 23, 2025
| Color(0xFF00B294), | ||
| Color(0xFF107C10), | ||
| Color(0xFF131440), | ||
| ]; |
There was a problem hiding this comment.
Consider creating named constants for each color to make their purpose clearer
for example:
'primary': Color(0xFF0A4D7E), // First blue
'warning': Color(0xFFD4540A), // Orange
'error': Color(0xFFA7101A), // Red
phoenixit99
reviewed
Jan 23, 2025
| /// TODO (by Pouria): add loading & error state after defining by UI team | ||
| case RequestStateEnum.loading: | ||
| return const SizedBox(); | ||
| case RequestStateEnum.initial: |
There was a problem hiding this comment.
The current loading state returns an empty SizedBox. This should be improved with a proper loading indicator
phoenixit99
reviewed
Jan 23, 2025
| ), | ||
| ); | ||
| case RequestStateEnum.error: | ||
| return const SizedBox(); |
There was a problem hiding this comment.
The current error state returns an empty SizedBox. This should provide visual feedback
phoenixit99
reviewed
Jan 23, 2025
| side: const BorderSide( | ||
| color: AppColors.borderColor, | ||
| width: 1, | ||
| ), |
There was a problem hiding this comment.
the border 'RoundedRectangleBorder' is duplicate. Consider create a common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.