PIN-4561 Resolved PR issue

pagopa · Feb 13, 2024 · 01cfdcb · 01cfdcb
1 parent 8062367
commit 01cfdcb
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/src/main/scala/it/pagopa/interop/catalogprocess/api/impl/ProcessApiServiceImpl.scala b/src/main/scala/it/pagopa/interop/catalogprocess/api/impl/ProcessApiServiceImpl.scala
@@ -552,17 +552,13 @@ final case class ProcessApiServiceImpl(
   private def deleteInterfaceOnTechnologyUpdate(newTechnology: EServiceTechnology, catalogItem: CatalogItem)(implicit
     contexts: Seq[(String, String)]
   ): Future[Unit] = {
-    if (catalogItem.descriptors.nonEmpty && catalogItem.technology.toApi != newTechnology)
-      for {
-        descriptor <- catalogItem.descriptors
-          .find(_.state == Draft)
-          .toFuture(EServiceCannotBeUpdated(catalogItem.id.toString))
-        _          <- descriptor.interface.traverse(interface =>
-          catalogManagementService
-            .deleteEServiceDocument(catalogItem.id.toString, descriptor.id.toString, interface.id.toString)
-        )
-      } yield ()
-    else Future.unit
+    if (catalogItem.technology.toApi != newTechnology) {
+      val descriptorAndInterface =
+        catalogItem.descriptors.find(_.state == Draft).flatMap(d => d.interface.map(i => (d, i)))
+      descriptorAndInterface.fold(Future.unit)(di =>
+        catalogManagementService.deleteEServiceDocument(catalogItem.id.toString, di._1.id.toString, di._2.id.toString)
+      )
+    } else Future.unit
   }
 
   private def deleteRiskAnalysisOnModeUpdate(newMode: EServiceMode, catalogItem: CatalogItem)(implicit