From 89ad8309ea9da579d64ca16692d92a3d2f5c5bc3 Mon Sep 17 00:00:00 2001
From: nttdata-rtorsoli <riccardo.torsoli@emeal.nttdata.com>
Date: Wed, 27 Sep 2023 17:33:01 +0200
Subject: [PATCH] PIN-3985 Resolved PR issues

---
 .../api/impl/ProcessApiServiceImpl.scala      | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/main/scala/it/pagopa/interop/catalogprocess/api/impl/ProcessApiServiceImpl.scala b/src/main/scala/it/pagopa/interop/catalogprocess/api/impl/ProcessApiServiceImpl.scala
index 26015070..d678eebf 100644
--- a/src/main/scala/it/pagopa/interop/catalogprocess/api/impl/ProcessApiServiceImpl.scala
+++ b/src/main/scala/it/pagopa/interop/catalogprocess/api/impl/ProcessApiServiceImpl.scala
@@ -693,22 +693,22 @@ object ProcessApiServiceImpl {
 
   def isRiskAnalysisFormValid(riskAnalysisForm: Commons.RiskAnalysisForm, schemaOnlyValidation: Boolean)(
     kind: Commons.RiskAnalysisTenantKind
-  )(implicit ec: ExecutionContext): Future[Unit] =
-    Future
-      .failed(RiskAnalysisNotValid)
-      .unlessA(
-        RiskAnalysisValidation
-          .validate(riskAnalysisForm, schemaOnlyValidation)(kind)
-          .isValid
-      )
+  ): Future[Unit] =
+    if (
+      RiskAnalysisValidation
+        .validate(riskAnalysisForm, schemaOnlyValidation)(kind)
+        .isValid
+    ) Future.unit
+    else Future.failed(RiskAnalysisNotValid)
 
   def isReceiveEService(eService: CatalogItem)(implicit ec: ExecutionContext): Future[Unit] =
     Future.failed(EServiceNotInReceiveMode(eService.id)).unlessA(eService.mode == Receive)
 
-  def isDraftEService(eService: CatalogItem)(implicit ec: ExecutionContext): Future[Unit] =
-    Future
-      .failed(EServiceNotInDraftState(eService.id))
-      .unlessA(eService.descriptors.map(_.state) == Seq(Draft))
+  def isDraftEService(eService: CatalogItem): Future[Unit] =
+    if (eService.descriptors.map(_.state) == Seq(Draft)) Future.unit
+    else
+      Future
+        .failed(EServiceNotInDraftState(eService.id))
 
   def assertRequesterAllowed(resourceId: UUID)(requesterId: UUID)(implicit ec: ExecutionContext): Future[Unit] =
     Future.failed(GenericComponentErrors.OperationForbidden).unlessA(resourceId == requesterId)