Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added metadata and auth flow #178

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

docs: added metadata and auth flow #178

wants to merge 7 commits into from

Conversation

himazawa
Copy link

No description provided.

@himazawa himazawa requested a review from a team as a code owner July 15, 2024 13:13
Copy link
Contributor

@BenitoVisone BenitoVisone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that in the auth_flow diagram we're missing two interactions between steps 6 and 7:

  1. update SAMLSession record with the SAMLResponse parameter after the redirect POST on the saml/acs endpoint
  2. init OIDCSession record after successful issuing of the authorization_code

chore: maybe it could be useful to add the /token POST request after the step 7. to make init of AccessTokenSession Record more explicit

Copy link
Contributor

@BenitoVisone BenitoVisone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In the auth_flow I would connect the /token to the API Gateway instead of directly to oneid-ecs-core
  2. In the metadata_flow I would add the Parameter Store dependency because the lambda will need it to sign and public the metadata with the certificate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants