Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [OI-249] spinner on idps fetch #549

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: [OI-249] spinner on idps fetch #549

wants to merge 2 commits into from

Conversation

mmoio
Copy link
Collaborator

@mmoio mmoio commented Nov 26, 2024 •
edited
Loading

  • button loading status while idps list is not populated
  • separete api functions
  • separet login data hook
  • separetd login buttons
  • unit test

image

@mmoio mmoio requested a review from sebbalex November 26, 2024 22:02
@mmoio mmoio self-assigned this Nov 26, 2024
@mmoio mmoio requested a review from a team as a code owner November 26, 2024 22:02
@mmoio mmoio marked this pull request as draft November 27, 2024 08:12
@mmoio mmoio force-pushed the feat/OI-249-idps-loading-status branch from 9fe2e4d to 7afb552 Compare November 29, 2024 08:35
@mmoio
feat: [OI-249] ogin refactoring
7d7ec3a 
- separete api functions
- separet login data hook
- separetd login buttons
- unit test
@mmoio mmoio force-pushed the feat/OI-249-idps-loading-status branch from 7afb552 to 7d7ec3a Compare November 29, 2024 09:24
@mmoio mmoio marked this pull request as ready for review November 29, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebbalex sebbalex Awaiting requested review from sebbalex

At least 1 approving review is required to merge this pull request.

Assignees

@mmoio mmoio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmoio