Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: P4ADEV-320-refactoring-accordingly-handbook #6

Merged
merged 20 commits into from
May 23, 2024
Merged

feat: P4ADEV-320-refactoring-accordingly-handbook #6

merged 20 commits into from
May 23, 2024

Conversation

LarissaASLeite
Copy link
Collaborator

Description

List of Changes

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@and-mora
Copy link
Contributor

do we plan to refactor the logback-spring.xml file?

@and-mora
Copy link
Contributor

is the MemoryAppender.java class needed?

@LarissaASLeite
Copy link
Collaborator Author

is the MemoryAppender.java class needed?

@LarissaASLeite LarissaASLeite marked this pull request as ready for review May 23, 2024 14:50
@LarissaASLeite LarissaASLeite requested review from antonioT90 and a team as code owners May 23, 2024 14:50
@LarissaASLeite LarissaASLeite merged commit 021dae7 into develop May 23, 2024
3 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@antonioT90 antonioT90 deleted the P4ADEV-320-refactoring-accordingly-handbook branch May 27, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@and-mora and-mora and-mora approved these changes

@antonioT90 antonioT90 Awaiting requested review from antonioT90 antonioT90 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarissaASLeite @and-mora