Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: P4ADEV-1247 apply new openApi version and maintain pre existing logics #92

Merged
merged 5 commits into from
Oct 16, 2024
Merged

feat: P4ADEV-1247 apply new openApi version and maintain pre existing logics #92

merged 5 commits into from
Oct 16, 2024

Conversation

macacia
Copy link
Collaborator

@macacia macacia commented Oct 15, 2024 •
edited
Loading

…logiche-pre-esistenti

Description

List of Changes

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@macacia macacia marked this pull request as ready for review October 15, 2024 14:31
antonioT90
antonioT90 requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@antonioT90 antonioT90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ExchangeTokenService.postToken verifying the mandatory fields not more validated by the Controller?
It should return 400 if not provided

openapi/p4pa-auth.openapi.yaml Outdated Show resolved Hide resolved
@macacia macacia changed the title feat: P4ADEV-1247-applicazione-nuova-versione-openApi-e-mantenimento-delle-logiche-pre-esistenti feat: P4ADEV-1247 apply new openApi version and maintain pre existing logics Oct 16, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@macacia macacia merged commit 71dfc12 into develop Oct 16, 2024
9 of 10 checks passed
@macacia macacia deleted the P4ADEV-1247-applicazione-nuova-versione-openApi-e-mantenimento-delle-logiche-pre-esistenti branch October 16, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioT90 antonioT90 antonioT90 approved these changes

@LarissaASLeite LarissaASLeite Awaiting requested review from LarissaASLeite LarissaASLeite is a code owner

@antocalo antocalo Awaiting requested review from antocalo antocalo is a code owner

@Benedetta-fabbri Benedetta-fabbri Awaiting requested review from Benedetta-fabbri Benedetta-fabbri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macacia @antonioT90