Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [P4ADEV-1477] Manage subpath on the dev server #3

Merged
merged 1 commit into from
Nov 27, 2024
Merged

chore: [P4ADEV-1477] Manage subpath on the dev server #3

merged 1 commit into from
Nov 27, 2024

Conversation

vito80ba
Copy link
Contributor

This PR add the support of the subpath also in the dev server (vite).

List of Changes

  • add env variable also in viteconfig

Motivation and Context

enhance the DX

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@vito80ba vito80ba requested review from a team as code owners November 26, 2024 16:40
@vito80ba vito80ba merged commit 483e83a into develop Nov 27, 2024
2 checks passed
@vito80ba vito80ba deleted the chore/P4ADEV-1477--subpath-webserver branch November 27, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abilello1 abilello1 abilello1 approved these changes

@antonioT90 antonioT90 antonioT90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vito80ba @antonioT90 @abilello1