Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [P4ADEV-2065] thankyou once page #78

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

vito80ba
Copy link
Contributor

This PR is a refactoring of the "thank you pages" using only once in a more general context called "responses".
The task is useful to set a one entry point to say "it's all ok" to the user

List of Changes

  • Drop thank you pages
  • add a more general page called Response / thank you
  • add a config file to manage different textes
  • update the translation file
  • add the business logic to the route (and unit test)

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

mmoio
mmoio previously approved these changes Feb 28, 2025
abilello1
abilello1 previously approved these changes Feb 28, 2025
@vito80ba vito80ba merged commit f2a22ef into develop Feb 28, 2025
5 checks passed
@vito80ba vito80ba deleted the feat/P4ADEV-2065--thankyou-once branch February 28, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants