Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid wrong rule duplication on single-rule update #12

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

andrea-deri
Copy link
Contributor

This PR contains the fix made in order to resolve a bug on rule update: if a rule is updated (also without editing a single field), it was wrongly duplicated with the same id and same order id. The same order ID caused the operation to fail during validation but if another order ID is set, the data is duplicated.
Also, some Terraform infrastructure resource names are updated for better naming them.

List of Changes

  • Resolved duplication bug, forcing a replace of the same rule in edit

Motivation and Context

These changes permits to resolve the wrong duplication of rule in edit operation

How Has This Been Tested?

  • Tested in local environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri self-assigned this Feb 15, 2024
@andrea-deri andrea-deri requested a review from a team as a code owner February 15, 2024 21:54
Copy link

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

@andrea-deri andrea-deri merged commit 94f26dd into main Feb 16, 2024
6 of 10 checks passed
@andrea-deri andrea-deri deleted the fix-error-on-update-rule branch February 16, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant