Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove http query params from destination file name release-2.x branch #287

Open
dmikusa opened this issue Sep 15, 2023 · 5 comments
Open

Remove http query params from destination file name release-2.x branch #287

dmikusa opened this issue Sep 15, 2023 · 5 comments
Labels
hacktoberfest Hacktoberfest eligible note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement v2 Work for v2 release

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Sep 15, 2023 •
edited
Loading

Describe the Enhancement

See #273

Motivation

See #273

Possible Solution

Port to release-2.x, but we also need to consider how this impacts offline usage.
@dmikusa dmikusa added type:enhancement A general enhancement note:ideal-for-contribution An issue that a contributor can help us with v2 Work for v2 release labels Sep 15, 2023
This was referenced Oct 2, 2023
Merged
Merged
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
@pranavek
Copy link

@dmikusa @anthonydahanne The changes on v1 are reverted. Shall we change the possible solution? If you could help me understand how you want to proceed with this, I can work on this.

@anthonydahanne
Copy link
Member

ah, that's a good point.
now since we're talking v2, I think it could apply here - wdyt @dmikusa ?
cc @pivotal-david-osullivan

@dmikusa
Copy link
Contributor Author

dmikusa commented Oct 17, 2023

Yes, I agree. You can resubmit the PR against the v2 branch. That will get things moving.

I do want to have another think through all this, to contemplate the offline use case. That's what was overlooked previously.

@loewenstein
Copy link

The title seems to be misleading... If I followed all the correct links, then the original PR #273 was reverted on main, right? I guess best would be to close this issue and instead reopen #274 - no?

@dmikusa dmikusa changed the title Port https://github.com/paketo-buildpacks/libpak/pull/273 to release-2.x branch Remove http query params from destination file name release-2.x branch May 13, 2024
@dmikusa
Copy link
Contributor Author

dmikusa commented May 13, 2024

@loewenstein I updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest eligible note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement v2 Work for v2 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anthonydahanne @loewenstein @dmikusa @pranavek