You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't expect assertj-automation to split the .hasMessage() into .hasLogMessage() and .containsArgs(), but I do think it should have introduced a usage of assertThatLoggableExceptionThrownBy() here.
The text was updated successfully, but these errors were encountered:
What happened?
This library creates a PR that fails to compile:
Ideally, these refactors would only produce changes that compile.
What did you want to happen?
Instead, this code ought to be using the more idiomatic
safe-logging:preconditions-assertj
library: https://github.com/palantir/safe-logging/tree/develop/preconditions-assertj/src/main/java/com/palantir/logsafe/testingHere is the change I manually created:
I don't expect assertj-automation to split the
.hasMessage()
into.hasLogMessage()
and.containsArgs()
, but I do think it should have introduced a usage ofassertThatLoggableExceptionThrownBy()
here.The text was updated successfully, but these errors were encountered: