remove the primitive optimization for boolean collections

palantir · Nov 5, 2024 · b41a46d · b41a46d
1 parent c91f0b9
commit b41a46d
Show file tree

Hide file tree

Showing 7 changed files with 107 additions and 96 deletions.
diff --git a/changelog/@unreleased/pr-2390.v2.yml b/changelog/@unreleased/pr-2390.v2.yml
@@ -0,0 +1,5 @@
+type: deprecation
+deprecation:
+  description: Remove Primitive Optimization for Boolean Collections
+  links:
+  - https://github.com/palantir/conjure-java/pull/2390
diff --git a/conjure-java-core/src/integrationInput/java/com/palantir/product/ListExample.java b/conjure-java-core/src/integrationInput/java/com/palantir/product/ListExample.java
diff --git a/...ure-java-core/src/integrationInput/java/test/prefix/com/palantir/product/ListExample.java b/...ure-java-core/src/integrationInput/java/test/prefix/com/palantir/product/ListExample.java
diff --git a/conjure-java-core/src/main/java/com/palantir/conjure/java/types/BeanBuilderGenerator.java b/conjure-java-core/src/main/java/com/palantir/conjure/java/types/BeanBuilderGenerator.java
@@ -1042,7 +1042,10 @@ private enum ConjureCollectionType {
         LIST("List"),
         DOUBLE_LIST("DoubleList"),
         INTEGER_LIST("IntegerList"),
-        BOOLEAN_LIST("BooleanList"),
+        // Eclipse has a BooleanList type, but this use case implies
+        // bit mask and it doesn't serialize efficiently as a collection
+        // so let's just use the "naive" boxed collection
+        BOOLEAN_LIST("List"),
         SAFE_LONG_LIST("SafeLongList"),
         SET("Set");
 

diff --git a/conjure-java-core/src/test/resources/example-types.yml b/conjure-java-core/src/test/resources/example-types.yml
@@ -74,6 +74,7 @@ types:
             safety: safe
           primitiveItems: list<integer>
           doubleItems: list<double>
+          booleanItems: list<boolean>
           optionalItems: list<optional<string>>
           aliasOptionalItems: list<OptionalAlias>
           nestedItems: list<list<string>>

diff --git a/conjure-lib/src/main/java/com/palantir/conjure/java/lib/internal/ConjureBooleanList.java b/conjure-lib/src/main/java/com/palantir/conjure/java/lib/internal/ConjureBooleanList.java