Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for container launcher-static configuration #149

Open
fryz opened this issue Apr 22, 2021 · 0 comments
Open

Support for container launcher-static configuration #149

fryz opened this issue Apr 22, 2021 · 0 comments

Comments

@fryz
Copy link

fryz commented Apr 22, 2021

In recent versions of Java, JVM memory configuration has become a bit more sophisticated with supporting launching processes in containers. Specifically, there is a desire to want to utilize some memory configuration flags that only work within containers (eg: MinRAMPercentage/MaxRAMPercentage), but this currently isn't possible with the launcher because it needs to support launching processes not in containers.

It's been proposed to bake some logic into go-java-launcher to detect the CONTAINER=true env var (see gradle-sls-docker's Dockerfile on internal github) and and then flip between a container launcher-static and a regular launcher-static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant