[FR] Error-prone check for detecting destructive Conjure builder methods being called in a loop

[viktornordling]

What happened?

Imagine you have this code:

MyConjureThing.Builder builder = MyConjureThing.builder();
Set<String> myValues = getValues();
for (String myValue : myValues) {
    Map<String, Integer> myMapping = calculateMap(myValue);
    builder.mapping(myMapping);
}
MyConjureThing thing = builder.build();

What this is going to do is leave you with only the myMapping from the last iteration, because instead of:

builder.mapping(myMapping);

you should have written:

builder.putAllMappings(myMapping);

It would be great if we could have an error-prone check to catch this.