WeakRef the as()'d objects

palantir · Dec 6, 2024 · 0f2dcb2 · 0f2dcb2
1 parent 6671a39
commit 0f2dcb2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/strange-dingos-clean.md b/.changeset/strange-dingos-clean.md
@@ -0,0 +1,5 @@
+---
+"@osdk/client": patch
+---
+
+Internal optimization to reduce memory usage for unused interface objects
diff --git a/packages/client/src/object/convertWireToOsdkObjects/getDollarAs.ts b/packages/client/src/object/convertWireToOsdkObjects/getDollarAs.ts
@@ -42,19 +42,20 @@ export const get$as = createSimpleCache<
 const osdkObjectToInterfaceView = createSimpleCache(
   new WeakMap<
     OsdkBase<any>,
-    Map<string, OsdkBase<any>>
+    Map<string, WeakRef<OsdkBase<any>>>
   >(),
   () =>
     new Map<
       /* interface api name */ string,
-      /* $as'd object */ OsdkBase<any>
+      /* $as'd object */ WeakRef<OsdkBase<any>>
     >(),
 );
 
 function $asFactory(
   objDef: FetchedObjectTypeDefinition,
 ): DollarAsFn {
   // We use the exact same logic for both the interface rep and the underlying rep
+
   return function $as<
     NEW_Q extends ObjectOrInterfaceDefinition,
   >(
@@ -98,13 +99,13 @@ function $asFactory(
 
     const existing = osdkObjectToInterfaceView
       .get(underlying)
-      .get(targetInterfaceApiName);
+      .get(targetInterfaceApiName)?.deref();
     if (existing) return existing;
 
     const osdkInterface = createOsdkInterface(underlying, def.def);
     osdkObjectToInterfaceView.get(underlying).set(
       targetInterfaceApiName,
-      osdkInterface,
+      new WeakRef(osdkInterface),
     );
     return osdkInterface;
   };