Merge pull request #104 from palantir/ssanjay/fixActionTypes

Fix action params
palantir · Mar 5, 2024 · 265ea37 · 265ea37
2 parents 5cae8ae + c4b11cf
commit 265ea37
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/client/changelog/@unreleased/pr-104.v2.yml b/packages/client/changelog/@unreleased/pr-104.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: Fix action params
+  links:
+  - https://github.com/palantir/osdk-ts/pull/104
diff --git a/packages/client/src/actions/Actions.ts b/packages/client/src/actions/Actions.ts
@@ -31,7 +31,7 @@ import type { Attachment } from "../object/Attachment.js";
 import type { Osdk, OsdkObjectPrimaryKeyType } from "../OsdkObjectFrom.js";
 import type { NOOP } from "../util/NOOP.js";
 import type { NullableProps } from "../util/NullableProps.js";
-import type { PartialByNotStrict } from "../util/PartialBy.js";
+import type { PartialBy } from "../util/PartialBy.js";
 import type { ActionReturnTypeForOptions } from "./applyAction.js";
 
 export type ApplyActionOptions =
@@ -67,7 +67,7 @@ type NotOptionalParams<X extends ActionParametersDefinition> = {
 export type OsdkActionParameters<
   X extends ActionParametersDefinition,
 > = NullableProps<X> extends never ? NotOptionalParams<X>
-  : PartialByNotStrict<NotOptionalParams<X>, NullableProps<X>>;
+  : PartialBy<NotOptionalParams<X>, NullableProps<X>>;
 
 export type ActionSignatureFromDef<T extends ActionDefinition<any, any, any>> =
   NonNullable<T["__OsdkActionType"]> extends never