Improve config

palantir · Dec 6, 2024 · c6364c6 · c6364c6
1 parent 9b0400c
commit c6364c6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/benchmarks/bundles/simple/package.json b/benchmarks/bundles/simple/package.json
@@ -8,7 +8,7 @@
     "url": "https://github.com/palantir/osdk-ts.git"
   },
   "scripts": {
-    "bundle:esbuild": "benchmarks.lib.bundler-esbuild"
+    "benchmark-parallel": "benchmarks.lib.bundler-esbuild"
   },
   "dependencies": {
     "@osdk/client": "workspace:*",

diff --git a/benchmarks/libraries/bundler-esbuild/src/index.ts b/benchmarks/libraries/bundler-esbuild/src/index.ts
@@ -57,8 +57,6 @@ export async function build(dirPath: string) {
             ? { platform: "node", target: "node18" }
             : {
               platform: "browser",
-              // this `conditions` entry SHOULD NOT exist if we have all of our configs right
-              conditions: ["import"],
             }),
           outfile: path.join(
             baseOutDir,