Fix asyncIter in legacy-client (#486)

* Fix asyncIter in legacy-client Tested changes * Add changeset
palantir · Jul 16, 2024 · cfa3db0 · cfa3db0
1 parent 9846af1
commit cfa3db0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/funny-gorillas-sniff.md b/.changeset/funny-gorillas-sniff.md
@@ -0,0 +1,5 @@
+---
+"@osdk/legacy-client": patch
+---
+
+Fix asyncIter to fetch more than one page
diff --git a/packages/legacy-client/src/client/net/loadObjectsPage.ts b/packages/legacy-client/src/client/net/loadObjectsPage.ts
@@ -112,7 +112,7 @@ export async function* loadObjectsIterator<
 ): AsyncIterableIterator<T> {
   let pageToken: string | undefined = undefined;
   do {
-    const result = await loadObjectsPage(
+    const result: Result<Page<T>, LoadObjectSetError> = await loadObjectsPage(
       client,
       objectApiName,
       objectSetDefinition,
@@ -121,6 +121,7 @@ export async function* loadObjectsIterator<
       { pageToken },
     );
     if (result.type === "ok") {
+      pageToken = result.value.nextPageToken;
       for (
         const obj of result.value.data
       ) {