Fix runtime warnings on AipNow template (#365)

Co-authored-by: Eran Witkon <[email protected]>
palantir · May 31, 2024 · e660cbd · e660cbd
1 parent f6d8850
commit e660cbd
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 14 deletions.
diff --git a/.changeset/itchy-radios-own.md b/.changeset/itchy-radios-own.md
@@ -0,0 +1,5 @@
+---
+"@osdk/create-app": patch
+---
+
+Fix runtime warnings on AipNow template
diff --git a/examples/example-tutorial-todo-app/src/CreateProjectDialog.tsx b/examples/example-tutorial-todo-app/src/CreateProjectDialog.tsx
@@ -39,10 +39,10 @@ function CreateProjectDialog({
     <Dialog
       isOpen={isOpen}
       buttons={[
-        <button disabled={isCreating} onClick={handleSubmit}>
+        <button disabled={isCreating} onClick={handleSubmit} key="create">
           Create project
         </button>,
-        <button disabled={isCreating} onClick={onClose}>
+        <button disabled={isCreating} onClick={onClose} key="cancel">
           Cancel
         </button>,
       ]}

diff --git a/examples/example-tutorial-todo-app/src/CreateTaskDialog.tsx b/examples/example-tutorial-todo-app/src/CreateTaskDialog.tsx
@@ -35,10 +35,10 @@ function CreateTaskDialog({ project, isOpen, onClose }: CreateTaskDialogProps) {
     <Dialog
       isOpen={isOpen}
       buttons={[
-        <button disabled={isCreating} onClick={handleSubmit}>
+        <button disabled={isCreating} onClick={handleSubmit} key="create">
           Create task
         </button>,
-        <button disabled={isCreating} onClick={onClose}>
+        <button disabled={isCreating} onClick={onClose} key="cancel">
           Cancel
         </button>,
       ]}

diff --git a/examples/example-tutorial-todo-app/src/DeleteProjectDialog.tsx b/examples/example-tutorial-todo-app/src/DeleteProjectDialog.tsx
@@ -31,10 +31,10 @@ function DeleteProjectDialog({
     <Dialog
       isOpen={isOpen}
       buttons={[
-        <button disabled={isDeleting} onClick={handleSubmit}>
+        <button disabled={isDeleting} onClick={handleSubmit} key="delete">
           Delete
         </button>,
-        <button disabled={isDeleting} onClick={onClose}>
+        <button disabled={isDeleting} onClick={onClose} key="cancel">
           Cancel
         </button>,
       ]}

diff --git a/examples/example-tutorial-todo-app/src/ProjectSelect.tsx b/examples/example-tutorial-todo-app/src/ProjectSelect.tsx
@@ -24,7 +24,7 @@ function ProjectSelect({
 
   return (
     <select value={project?.id} onChange={handleSelect}>
-      <option hidden disabled selected>
+      <option hidden disabled value="">
         -- select a project --
       </option>
 

diff --git a/packages/create-app/templates/template-tutorial-todo-app/src/CreateProjectDialog.tsx b/packages/create-app/templates/template-tutorial-todo-app/src/CreateProjectDialog.tsx
@@ -39,10 +39,10 @@ function CreateProjectDialog({
     <Dialog
       isOpen={isOpen}
       buttons={[
-        <button disabled={isCreating} onClick={handleSubmit}>
+        <button disabled={isCreating} onClick={handleSubmit} key="create">
           Create project
         </button>,
-        <button disabled={isCreating} onClick={onClose}>
+        <button disabled={isCreating} onClick={onClose} key="cancel">
           Cancel
         </button>,
       ]}

diff --git a/packages/create-app/templates/template-tutorial-todo-app/src/CreateTaskDialog.tsx b/packages/create-app/templates/template-tutorial-todo-app/src/CreateTaskDialog.tsx
@@ -35,10 +35,10 @@ function CreateTaskDialog({ project, isOpen, onClose }: CreateTaskDialogProps) {
     <Dialog
       isOpen={isOpen}
       buttons={[
-        <button disabled={isCreating} onClick={handleSubmit}>
+        <button disabled={isCreating} onClick={handleSubmit} key="create">
           Create task
         </button>,
-        <button disabled={isCreating} onClick={onClose}>
+        <button disabled={isCreating} onClick={onClose} key="cancel">
           Cancel
         </button>,
       ]}

diff --git a/packages/create-app/templates/template-tutorial-todo-app/src/DeleteProjectDialog.tsx b/packages/create-app/templates/template-tutorial-todo-app/src/DeleteProjectDialog.tsx
@@ -31,10 +31,10 @@ function DeleteProjectDialog({
     <Dialog
       isOpen={isOpen}
       buttons={[
-        <button disabled={isDeleting} onClick={handleSubmit}>
+        <button disabled={isDeleting} onClick={handleSubmit} key="delete">
           Delete
         </button>,
-        <button disabled={isDeleting} onClick={onClose}>
+        <button disabled={isDeleting} onClick={onClose} key="cancel">
           Cancel
         </button>,
       ]}

diff --git a/packages/create-app/templates/template-tutorial-todo-app/src/ProjectSelect.tsx b/packages/create-app/templates/template-tutorial-todo-app/src/ProjectSelect.tsx
@@ -24,7 +24,7 @@ function ProjectSelect({
 
   return (
     <select value={project?.id} onChange={handleSelect}>
-      <option hidden disabled selected>
+      <option hidden disabled value="">
         -- select a project --
       </option>