Update $in to accept readonly (#965) (#968)

* Update Where In to be Readonly * changeset * Add small test * changeset
palantir · Nov 13, 2024 · eae3b9e · eae3b9e
1 parent fa5119a
commit eae3b9e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/rich-cats-jog.md b/.changeset/rich-cats-jog.md
@@ -0,0 +1,6 @@
+---
+"@osdk/client": patch
+"@osdk/api": patch
+---
+
+Allows $in to take a readonly array
diff --git a/packages/api/src/aggregate/WhereClause.ts b/packages/api/src/aggregate/WhereClause.ts
@@ -50,7 +50,7 @@ type MakeFilter<K extends PossibleWhereClauseFilters, V> = K extends string ? {
 type BaseFilter<T> =
   | T
   | MakeFilter<"$eq" | "$ne", T>
-  | MakeFilter<"$in", Array<T>>
+  | MakeFilter<"$in", ReadonlyArray<T>>
   | MakeFilter<"$isNull", boolean>;
 
 type StringFilter =

diff --git a/packages/client/src/objectSet/ObjectSet.test.ts b/packages/client/src/objectSet/ObjectSet.test.ts
@@ -293,6 +293,14 @@ describe("ObjectSet", () => {
     }
   });
 
+  it("allows $in filter with ReadonlyArrays", () => {
+    const ids: ReadonlyArray<number> = [50030, 50031];
+    const objectSet = client(Employee).where({
+      employeeId: { $in: ids },
+    });
+    expect(objectSet).toBeDefined();
+  });
+
   describe.each(["fetchPage", "fetchPageWithErrors"] as const)("%s", (k) => {
     // describe("strictNonNull: \"drop\"", () => {
     //   describe("includeRid: true", () => {