Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle version/autoVersion selection in the parsing layer #52

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

zeyadkhaled
Copy link
Member

The handling layer needed to know about the internals of the parsing layer where version and autoVersion could be defined at the same time due to how default is being used in the autoVersion yargs option. This introduces a new type just for the handler arguments with a unionType selectedVersion that helps remove any confusion about which key from the parsed args to use.

@changelog-app
Copy link

changelog-app bot commented Feb 12, 2024

Generate changelog in packages/cli/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Handle version/autoVersion selection in the parsing layer

Check the box to generate changelog(s)

  • Generate changelog entry

@zeyadkhaled zeyadkhaled assigned zeyadkhaled and tzyl and unassigned zeyadkhaled Feb 12, 2024
packages/cli/src/commands/site/deploy/index.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/site/deploy/index.ts Outdated Show resolved Hide resolved
@bulldozer-bot bulldozer-bot bot merged commit 1448934 into main Feb 14, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the zka/improve-handler-layer branch February 14, 2024 13:44
ericanderson added a commit that referenced this pull request Feb 14, 2024
…tions

* origin/main:
  Update api-gateway definitions (#38)
  Update copyright to use new Date() (#66)
  fix generate type
  restrict object :
  add bulk no params options
  Autorelease
  Autorelease
  Update ExitProcessError tips and use option instead of argument (#63)
  Harmonize usage of options `foundryUrl` & `clientId` across all cli commands (#50)
  Address minor TODOs (#55)
  CLI error tips (#61)
  Include repository link in package.json (#60)
  Handle version/autoVersion selection in the parsing layer (#52)
  Add generated changelog entries
  Add helper
  Add generated changelog entries
  remove commented out code
  one more change
  add intersects
  Autorelease
  Refactor site link consola box code (#58)
  Prompt user for destructive commands (#56)
  Display site link after deploy (#57)
  Review CLI wording (#54)
  use helper function
  remove anys
  Fix bulk action type
  Add generated changelog entries
  one more refactor
  refactor
  bulk actions fix
  second attempt bulk actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants