-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle version/autoVersion selection in the parsing layer #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
tzyl
approved these changes
Feb 13, 2024
packages/cli/src/commands/site/deploy/SiteDeployCommandHandlerArgs.ts
Outdated
Show resolved
Hide resolved
ericanderson
added a commit
that referenced
this pull request
Feb 14, 2024
…tions * origin/main: Update api-gateway definitions (#38) Update copyright to use new Date() (#66) fix generate type restrict object : add bulk no params options Autorelease Autorelease Update ExitProcessError tips and use option instead of argument (#63) Harmonize usage of options `foundryUrl` & `clientId` across all cli commands (#50) Address minor TODOs (#55) CLI error tips (#61) Include repository link in package.json (#60) Handle version/autoVersion selection in the parsing layer (#52) Add generated changelog entries Add helper Add generated changelog entries remove commented out code one more change add intersects Autorelease Refactor site link consola box code (#58) Prompt user for destructive commands (#56) Display site link after deploy (#57) Review CLI wording (#54) use helper function remove anys Fix bulk action type Add generated changelog entries one more refactor refactor bulk actions fix second attempt bulk actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling layer needed to know about the internals of the parsing layer where version and autoVersion could be defined at the same time due to how default is being used in the autoVersion yargs option. This introduces a new type just for the handler arguments with a unionType
selectedVersion
that helps remove any confusion about which key from the parsed args to use.