Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to add a service dependency for new conjure projects #1524

Open
mswintermeyer opened this issue Sep 28, 2023 · 0 comments
Open

Comments

@mswintermeyer
Copy link

What happened?

When adding conjure projects in a repo, no serviceDependency block is added automatically, nor is there any validation to check that one was added. Thus, the default is to not add one. And that's unsafe because other services can add a client dependency on the API, and have that not enforced with pdeps.

What did you want to happen?

There should be validation that enforces that for each module defining conjure APIs, either a compliant serviceDependency block is added or people configure some variable in build.gradle signifying that this API is not only hosted by a service in the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant