Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] When enabled, hprof heap dumps are written to var/log #424

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

raiju
Copy link
Contributor

@raiju raiju commented Feb 13, 2019

Fixes #423

@raiju raiju requested a review from a team as a code owner February 13, 2019 16:45
@ferozco
Copy link
Contributor

ferozco commented Feb 13, 2019

@raiju We set CrashOnOutOfMemoryError so no heap dump should be produced

@carterkozak
Copy link
Contributor

@ferozco The two parameters are not mutually exclusive, the crash occurs after a heap dump is written to disk. While we do not enable -XX:+HeapDumpOnOutOfMemoryError by default, it is reasonable to enable while monitoring/debugging a failing service.

@ferozco
Copy link
Contributor

ferozco commented Feb 13, 2019

Ok, I thought that they were. I'm hesitant to encourage enabling heap dumps though. Enabling heap dumps can be a foot gun since a bad release of a single service could crash multiple times taking down the box with it because the disk fills up.

@raiju
Copy link
Contributor Author

raiju commented Feb 14, 2019

@ferozco This isn't enabling heap dumps. It's only specifying where heap dumps are written if enabled so we can hook it into our metrics (alert on heap dump creation), and is in a place where there is some file rotation policy in place.

@ferozco
Copy link
Contributor

ferozco commented Feb 14, 2019

👍

@iamdanfox iamdanfox changed the title [improvement] Write hprof heap dumps to var/log [improvement] When enabled, hprof heap dumps are written to var/log Feb 14, 2019
@bulldozer-bot bulldozer-bot bot merged commit 401a6a3 into palantir:develop Feb 14, 2019
@robert3005
Copy link
Contributor

@raiju can you point me to the services which are producing heap dumps that you care about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify hprof directory
5 participants