Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classpath generated with enableManifestClasspath is missing entries #476

Open
joncelay opened this issue Mar 28, 2019 · 0 comments · Fixed by #477
Open

Classpath generated with enableManifestClasspath is missing entries #476

joncelay opened this issue Mar 28, 2019 · 0 comments · Fixed by #477

Comments

@joncelay
Copy link
Contributor

When using enableManifestClasspath, the main module jar is not added to the generated classpath.

As a result, the main class cannot be resolved and the application fails to start.

The problem can also be observed by comparing the classpath generated with and without the enableManifestClasspath flag.
joncelay added a commit to joncelay/sls-packaging that referenced this issue Mar 28, 2019
@joncelay
Add project output jar to the generated MANIFEST
4b135ad 
This is to resolve palantir#476
joncelay added a commit to joncelay/sls-packaging that referenced this issue Mar 28, 2019
@joncelay
Assert presence of project jar in jar MANIFEST
43b7c53 
Test for resolution of palantir#476
joncelay added a commit to joncelay/sls-packaging that referenced this issue Mar 28, 2019
@joncelay
Assert presence of project jar in jar MANIFEST
24d9477 
Test for resolution of palantir#476
@joncelay joncelay mentioned this issue Mar 28, 2019
Merged
bulldozer-bot bot pushed a commit that referenced this issue Mar 28, 2019
@joncelay @bulldozer-bot
Fix missing jars in classpath of generared in jar MANIFEST (#477)
e5068c6 
fixes #476 

Classpath in jar MANIFEST  now contains the project jars and is consistent with the classpath generated in launcher script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing jars in classpath of generared in jar MANIFEST joncelay/sls-packaging
1 participant
@joncelay