Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraction of binary files causes truncation, loss of header, and corruption of raw data. #5

Open
playaspec opened this issue May 14, 2018 · 0 comments

Comments

@playaspec
Copy link

playaspec commented May 14, 2018

FileTypeBIN in function AppleDOSReadFileRaw parses out load address and length from file and returns load address, length, and data. When AppleDOSReadFileRaw is called from within analyzeDOS16, the load address and length are discarded, and a new, incorrect load address is extracted from the data segment, and the returned data is further truncated by the two bytes that were wrongly interpreted as an address. In all, the first 6 bytes of exported binary files are lost.

To truly return a RAW file, both the load address and length headers should remain intact in the extracted file, instead of the now useless, mangled file that is returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant