Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing support to project #2440

Open
Abdur-rahmaanJ opened this issue Jul 8, 2024 · 1 comment
Open

Add typing support to project #2440

Abdur-rahmaanJ opened this issue Jul 8, 2024 · 1 comment
Assignees
@samuelhwilliams
Labels
code quality

Comments

@Abdur-rahmaanJ
Copy link
Member

  1. Run mypy without strict flag, fix issues
  2. Run mypy with strict flag, fix issues
  3. Enable typing in tests once again
@samuelhwilliams
Copy link
Contributor

samuelhwilliams commented Jul 13, 2024 •
edited
Loading

To do list:

  • Re-enable the typing github action
  • Re-enable warn_unused_configs in pyproject.toml
  • Re-enable warn_redundant_casts in pyproject.toml
  • Re-enable warn_unused_ignores in pyproject.toml
  • Re-enable strict_equality in pyproject.toml
  • Re-enable strict_concatenate in pyproject.toml
  • Re-enable check_untyped_defs in pyproject.toml
  • Re-enable disallow_subclassing_any in pyproject.toml
  • Re-enable disallow_untyped_decorators in pyproject.toml
  • Re-enable disallow_any_generics in pyproject.toml
  • Re-enable disallow_untyped_calls in pyproject.toml
  • Re-enable disallow_incomplete_defs in pyproject.toml
  • Re-enable disallow_untyped_defs in pyproject.toml
  • Re-enable no_implicit_reexport in pyproject.toml
  • Re-enable warn_return_any in pyproject.toml
  • Resolve/remove any type: ignore comments
  • Resolve/remove any [[tool.mypy.override]] blocks in pyproject.toml

@samuelhwilliams samuelhwilliams self-assigned this Jul 13, 2024
@samuelhwilliams samuelhwilliams mentioned this issue Jul 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelhwilliams samuelhwilliams

Labels
code quality
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samuelhwilliams @Abdur-rahmaanJ