Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the "Xbull Wallet pops up when signing a transaction with freigther" #65

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

josephchimebuka
Copy link

@josephchimebuka josephchimebuka commented Aug 24, 2024

fixes #60
Refactored wallet connection logic

Copy link

vercel bot commented Aug 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-soroban-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 1:21am
create-soroban-dapp-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 1:21am

@josephchimebuka josephchimebuka changed the title Enhance wallet connection process in ConnectButton Fixed the "Xbull Wallet pops up when signing a transaction with freigther" Aug 24, 2024
@MattPoblete
Copy link
Contributor

Grabacion.de.pantalla.2024-08-27.a.la.s.1.29.04.p.m.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file for PR

soroban-react-dapp/package-lock.json Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove for pr

@josephchimebuka
Copy link
Author

@MattPoblete I have removed the yarn.lock file

@chopan123
Copy link
Member

remove package-lock also

@josephchimebuka
Copy link
Author

@chopan123 I have removed it ser

@chopan123
Copy link
Member

I would like to have the yarn.lock from before

@josephchimebuka
Copy link
Author

josephchimebuka commented Sep 4, 2024

I would like to have the yarn.lock from before

I thought you said I should remove it ser?... I have added it back ser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xbull Wallet pops up when signing a transaction with freigther
3 participants