Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for network connector (read Blockchain without wallet) #12

Closed
esteblock opened this issue Jan 9, 2023 · 6 comments
Closed
Assignees

Comments

@esteblock
Copy link
Member

No description provided.

@esteblock
Copy link
Member Author

How to replicate this:
Follow the instructions in https://github.com/esteblock/multichain-dapp/issues
You will see that if you don't connet your wallet, the frontend is unable to see any Blockchain.
We should be able to tell the frontend what is a default Soroban RPC

@benjaminsalon
Copy link
Collaborator

How to replicate this: Follow the instructions in https://github.com/esteblock/multichain-dapp/issues You will see that if you don't connet your wallet, the frontend is unable to see any Blockchain. We should be able to tell the frontend what is a default Soroban RPC

I don't see any issues with the link you sent

@benjaminsalon
Copy link
Collaborator

But I understand it, when starting the multichain dapp before connecting the wallet we cannot read the title of the contract, is that what is about @esteblock ?

@esteblock
Copy link
Member Author

How to replicate this: Follow the instructions in https://github.com/esteblock/multichain-dapp/issues You will see that if you don't connet your wallet, the frontend is unable to see any Blockchain. We should be able to tell the frontend what is a default Soroban RPC

I don't see any issues with the link you sent

I ment just https://github.com/esteblock/multichain-dapp XD

@esteblock
Copy link
Member Author

But I understand it, when starting the multichain dapp before connecting the wallet we cannot read the title of the contract, is that what is about @esteblock ?

Yes. The problem is that now we cannot read the blockchain if the user does not connects the Wallet (which provides netoworkDetails and provides the sorobanRpcUrl)

We need to set a new connector called "network" that the frontend dev will define a SorobanRpcUrl
It will be read-only

@esteblock
Copy link
Member Author

Hello @benjaminsalon This was solved in #64 and #63

However, there are still a lot of things to clean.
There is no need to have NetworkDetails, WalletChain, ChainName, ChainMetadata...
Will open a new issue for that: #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants