Beginning of acceptance test framework #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasuiniko
force-pushed
the
acceptance
branch
2 times, most recently
from
8857edd to
9984392
Compare
|
The tests are failing because Scheduler imports typing.Self, which was implemented in Python 3.11. The import is not from my code, it is from main. Should we stop testing python 3.10? |
|
|
@andnp we need your advice here. The Github workflow tests for this PR are failing because of two issues
I can fix both of these issues by editing |
This test includes some janky passing of results path. Needs to be fixed outside of test. Towards: #8
This makes pytest compatible with _utils.path.get_experiment_name() Fixes: #18
|
Yup, I think editing the workflow spec to solve both of these is a great strategy! I'm quite comfortable dropping 3.10 support |
|
Below tests are those on the main branch, the PR has an updated test.yaml and those pass when run locally through https://github.com/nektos/act. This fixes #20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of an acceptance test using mountaincar and softmaxAC. So far I have done:
tests/acceptance/softmaxAC_mc.pywith a test that writes to a database usingDefinitionPartand reads from it usingExperimentDefinition.tests/test_generate_configurations.py, which tests the function inDefinitionPart.py.