Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyphen bug in MetadataTableRegistry #16

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fix hyphen bug in MetadataTableRegistry #16

merged 2 commits into from
Oct 30, 2024

Conversation

yasuiniko
Copy link
Collaborator

Access part names by reverse splitting on the hyphen instead of forward splitting. Fixes #15

Copy link
Owner

@panahiparham panahiparham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yasuiniko yasuiniko merged commit f01b1fa into main Oct 30, 2024
7 checks passed
@yasuiniko yasuiniko deleted the meta-name-fix branch October 30, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Part names in tables can't have hyphens
2 participants