From d7680bd4cf4d1dee64517b2190089970186d8bb2 Mon Sep 17 00:00:00 2001 From: Mark Mankins Date: Mon, 19 Aug 2024 14:10:17 -0600 Subject: [PATCH] Correct documentation. panda_virtual_memory_* and panda_physical_memory_* return non-zero values on error. These can be positive - in fact in the case of panda_physical_memory_* there are only two possible values currently, 0 and 1. --- panda/docs/manual.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/panda/docs/manual.md b/panda/docs/manual.md index d1df68b3a70..962e0cab52f 100644 --- a/panda/docs/manual.md +++ b/panda/docs/manual.md @@ -295,7 +295,7 @@ int panda_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, int len, int This function allows a plugin to read or write `len` bytes of guest physical memory at `addr` into or from the supplied buffer `buf`. This function differs from QEMU's `cpu_physical_memory_rw` in that it will never access I/O, only -RAM. This function returns zero on success, and negative values on failure (page not mapped). +RAM. This function returns zero on success, and non-zero values on failure (page not mapped). ```C int panda_virtual_memory_rw(CPUState *env, target_ulong addr, uint8_t *buf, int len, int is_write); ```