Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: source .c files under _lib/src being gitignored. #42116

Open
3 tasks done
dalejung opened this issue Jun 19, 2021 · 3 comments
Open
3 tasks done

BUG: source .c files under _lib/src being gitignored. #42116

dalejung opened this issue Jun 19, 2021 · 3 comments
Labels
Bug Build Library building on various platforms

Comments

@dalejung
Copy link
Contributor

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.

Straight forward issue. Not all .c files are generated and shouldn't be ignored. Problematic for code searching tools that are set to respect .gitignore files. Ran into this when doing rg to search for on_bad_lines and never saw the matches in _libs/src/tokenizer.c
@dalejung dalejung added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 19, 2021
dalejung added a commit to dalejung/pandas that referenced this issue Jun 19, 2021
@dalejung
BUG: Unignore .c files under _libs/src. pandas-dev#42116
0e09468
dalejung added a commit to dalejung/pandas that referenced this issue Jun 19, 2021
@dalejung
BUG: Unignore .c files under _libs/src. (pandas-dev#42116)
de44926
@dalejung dalejung mentioned this issue Jun 19, 2021
Closed
1 task
@simonjayhawkins simonjayhawkins added Build Library building on various platforms and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 19, 2021
@simonjayhawkins
Copy link
Member

Thanks @dalejung for the report. see also #41981 as somewhat related. Is there a way to keep parts of .gitignore and MANIFEST.in in sync

dalejung added a commit to dalejung/pandas that referenced this issue Jun 19, 2021
@dalejung
BUG: Unignore .c files under _libs/src. (pandas-dev#42116)
9be6afd 
BUG: Remove unneeded gitignore lines. (pandas-dev#42116)
@jbrockmendel
Copy link
Member

@lithomas1 has this been handled?

@lithomas1
Copy link
Member

lithomas1 commented Jul 25, 2023 •
edited
Loading

Nope, but the entries in gitignore for *.cpp and *.c can be straight up removed now, since Cython C/C++ files are not generated in the source tree anymore.

Should be pretty easy to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Build Library building on various platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Unignore .c files under _libs/src. (#42116) dalejung/pandas
4 participants
@dalejung @jbrockmendel @simonjayhawkins @lithomas1