Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Update MANIFEST.in #41981

Merged
merged 8 commits into from
Jun 13, 2021
Merged

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jun 13, 2021

@simonjayhawkins simonjayhawkins added the Build Library building on various platforms label Jun 13, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jun 13, 2021
@simonjayhawkins
Copy link
Member Author

The pip-test and conda-test steps of the release process pass with this patch.

@simonjayhawkins
Copy link
Member Author

The pip-test and conda-test steps of the release process pass with this patch.

I should have said locally.

I think the reason that the ci action https://github.com/simonjayhawkins/pandas-release/actions/runs/932775977 is failing for the conda-test maybe due to the conda recipe being removed from the pandas repo in 1.3. This is a separate issue and maybe an error in the "unofficial" ci scripts there. Will investigate further.

@simonjayhawkins
Copy link
Member Author

I think the reason that the ci action https://github.com/simonjayhawkins/pandas-release/actions/runs/932775977 is failing for the conda-test maybe due to the conda recipe being removed from the pandas repo in 1.3. This is a separate issue and maybe an error in the "unofficial" ci scripts there. Will investigate further.

the scripts are failing for 1.2.5 now too. so something else has changed in the last few days. not relevant for this PR.

@simonjayhawkins simonjayhawkins mentioned this pull request Jun 13, 2021
@jreback
Copy link
Contributor

jreback commented Jun 13, 2021

yeah we removed the conda recioe

i think we can remove this action as well as the conda recioe is maintained externally

@simonjayhawkins
Copy link
Member Author

i think we can remove this action as well as the conda recioe is maintained externally

the action is maintained by me on my personal branch to avoid surprises when doing the release and as a basis for the release automation #21050 and #36704

but that's not relevant to this PR. OK to merge?

@jreback
Copy link
Contributor

jreback commented Jun 13, 2021

sure

@simonjayhawkins simonjayhawkins merged commit 0b68d87 into pandas-dev:master Jun 13, 2021
@simonjayhawkins simonjayhawkins deleted the manifest branch June 13, 2021 16:39
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 13, 2021
simonjayhawkins added a commit that referenced this pull request Jun 13, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants