Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Unignore .c files under _libs/src. (#42116) #42117

Closed
wants to merge 1 commit into from
Closed

BUG: Unignore .c files under _libs/src. (#42116) #42117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@ scikits
# Generated Sources #
#####################
!skts.c
!np_datetime.c
!np_datetime_strings.c
*.c
*.cpp
# Unignore source c files
!pandas/_libs/src/**/*.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The np_datetime.c and np_datetime_strings.c above are in pandas/_libs/tslibs/src

maybe would could include .c files under any directory named src in the _libs tree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the np lines since they are caught by my new line. The line I added will ignore all c files under src/ so we're good there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be !pandas/_libs/**/src/**/*.c so that any .c files added to the pandas/_libs/tslibs/src are included in the future.


# Unit / Performance Testing #
##############################
Expand Down