Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better OpenExchangeRates error reporting #38

Closed
rjmoggach opened this issue Aug 6, 2016 · 5 comments
Closed

better OpenExchangeRates error reporting #38

rjmoggach opened this issue Aug 6, 2016 · 5 comments

Comments

@rjmoggach
Copy link

Changing the base currency from USD to some other currency requires a paid account with OpenExchangeRates.

Currently the API returns an error that doesn't make this clear at first glance:

openexchangerates.OpenExchangeRatesClientException: 
403 Client Error: Forbidden for url: http://openexchangerates.org/
api/latest.json?app_id=xxxxxxxxxxxxxxx&base=GBP

Copying the request URL to another tab reveals the problem but this exception should be handled appropriately.

@racitup
Copy link
Collaborator

racitup commented Oct 4, 2016

Should now be fixed on my fork which has completely restructured the management commands to integrate other sources. Yahoo Finance now integrated. Check it out!

I am just going to raise a pull request :-)

@bashu
Copy link
Contributor

bashu commented Oct 4, 2016

@racitup +1 for PR

@einarf
Copy link
Contributor

einarf commented Nov 16, 2016

@racitup @bashu I wonder if you might be better off just moving the actual openexchangerates module into this project. It seems to be abandoned and do not support python 3 because of this tiny bug that has a PR waiting for almost a year metglobal/openexchangerates#6

openexchangerates has an MIT license so that should not be a problem.

@panosl
Copy link
Owner

panosl commented Nov 22, 2016

Show me the pull requests :)

@racitup
Copy link
Collaborator

racitup commented Nov 22, 2016

See PR #43 :)

@panosl panosl closed this as completed Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants