Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring Settings.php D8 Doc Update #918

Closed
3 tasks done
nataliejeremy opened this issue Sep 14, 2015 · 6 comments
Closed
3 tasks done

Configuring Settings.php D8 Doc Update #918

nataliejeremy opened this issue Sep 14, 2015 · 6 comments
Assignees
Labels
Type: New Content Request for or PR containing new content to existing page
Milestone

Comments

@nataliejeremy
Copy link
Contributor

Re: Configuring Settings.php

Issue Description:

Suggested Resolution

  • Update intro content to specify Pressflow Drupal is for D7, and add info on D8.
  • Add code snippets for Drupal 8 under “Local Database Configuration for Development”
  • Add link to D8 default.settings.php under the FAQ "Where can I get a copy of a default.settings.php?"
@nataliejeremy nataliejeremy added the Type: New Content Request for or PR containing new content to existing page label Sep 14, 2015
@nataliejeremy nataliejeremy added this to the D8 milestone Sep 14, 2015
@bmackinney
Copy link
Contributor

@timani @greg please review this issue, and edit the description if inaccurate, and +1 before @timani starts

@bmackinney
Copy link
Contributor

@timani it looks like you've done most of this already here: https://github.com/pantheon-systems/pantheon-settings-examples/tree/master/drupal-8

@timani
Copy link
Contributor

timani commented Oct 9, 2015

Oh right, I remember starting this but it does need an update to be complete

@ttrowell
Copy link
Contributor

ttrowell commented Nov 6, 2015

Also, as a 'hash_salt' setting is needed, should we include a method for users to add that to their settings.php for their local environment? We set it per environment with the following code:

 * Handle Hash Salt Value from Drupal
 *
 * Issue: https://github.com/pantheon-systems/drops-8/issues/10
 *
 */
if (isset($_ENV['PANTHEON_ENVIRONMENT'])) {
  $settings['hash_salt'] = $_ENV['DRUPAL_HASH_SALT'];
}```

@rachelwhitton
Copy link
Member

#1097 was created as a duplicate - adding related description here. @timani are you planning a PR for this issue?

Re: Configuring Settings.php

Issue Description:

Drupal 8 includes a bundled settings.php file, unlike previous versions.

Suggested Resolution

Update doc throughout as needed to align with Drupal 8, while preserving suggestions/best practices already mentioned that apply to D6/D7.

See note from Greg:

Do we want to say anything about the fact that Drupal 8 sites do come with a bundled settings.php? Also, the bundled settings.php and default.settings.php both include the necessary settings.pantheon.inc. If someone used a stock default.settings.php, their Drupal 8 site would stop working. Maybe we should have another document that describes settings.php for Drupal 8 (did not check to see if that already exists), and just cross-link to it here?

@greg-1-anderson
Copy link
Member

Yes, folks should make their own HASH_SALT value in their settings.local.php file. See:

https://github.com/pantheon-systems/drush-config-workflow/blob/master/bin/quickstart

If for some reason someone wants to use the Pantheon HASH_SALT in their local site (not necessary), then can get it via:

drush @pantheon.sitename.dev ev 'return getenv("DRUPAL_HASH_SALT")'

c.f. pantheon-systems/drops-8#103

rachelwhitton pushed a commit that referenced this issue Nov 20, 2015
Closes #918

- Revise intro w/d8 conent
 - Warn against replacing the bundled settings.php file
 - States that d8 on pantheon uses an unmodified version of core
- Add D8 section on local environment configs, recommends settings.local.php and links to drush quickstart script
 - Provide Terminus drush command to retrun HASH_SALT value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Content Request for or PR containing new content to existing page
Projects
None yet
Development

No branches or pull requests

6 participants