Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complementing zombienet tutorial with terminal outputs #40

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

nhussein11
Copy link
Contributor

This PR aims to solve this ticket: https://opslayer.atlassian.net/browse/DRP-45

@albertov19
Copy link
Collaborator

@nhussein11 can you address Vale's comments? If this is not relevant anymore please close this PR

@nhussein11
Copy link
Contributor Author

@albertov19, Vale's comments were unnecessary here and have been marked as solved.

I'm waiting for a review here. However, this is not a high priority; it was just something we discussed with Erin and it would be nice to have.

Probably after getting approval here, we can merge it and then port it to the polkadot-docs repo.

@eshaben eshaben self-requested a review September 24, 2024 13:56
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben merged commit 91e8b14 into main Sep 24, 2024
1 check failed
@eshaben eshaben deleted the nhussein11/fix-zombienet-reformatting branch September 24, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants