Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfiles have some architecture hardcoding for x86 #643

Open
ericvh opened this issue Oct 15, 2022 · 2 comments
Open

Dockerfiles have some architecture hardcoding for x86 #643

ericvh opened this issue Oct 15, 2022 · 2 comments

Comments

@ericvh
Copy link

ericvh commented Oct 15, 2022

Ran into this while trying to build the e2e_tests/docker_image on an M1

 => ERROR [34/54] RUN cd nanopb-0.4.4-linux-x86  && cmake .  && make  && make install                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                0.2s
------
 > [34/54] RUN cd nanopb-0.4.4-linux-x86        && cmake .      && make         && make install:
#37 0.188 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory
@mohamedasaker-arm
Copy link
Contributor

Thanks @ericvh for creating the issue. Could you give more details about what you were trying to achieve?
The docker image is intended to run e2e_tests, so targeting a specific architecture (The CI one) was okay.
Do you think we could benefit from generalizing the docker image or have different ones for different architectures?

@ericvh
Copy link
Author

ericvh commented Nov 7, 2022

I think we should be arm64 by default and multiarch (at least linux/arm64 and ideally linux/arm/v7 in addition to amd64) - its easy enough to do nowdays, I can show you my multi-arch github CI if you like which generates signed buildx docker multiarch manfiests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants